Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC 128: Consume User Activation #128

Merged
merged 4 commits into from
Apr 4, 2023
Merged

RFC 128: Consume User Activation #128

merged 4 commits into from
Apr 4, 2023

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Nov 18, 2022 •
edited
Loading

See details in the proposed .md.

tl;dr: this is a proposal to add...

 /**
  * Consumes the user activation
  *
  * Matches the behavior of the `Consume User Activation of window`
  * as proposed in: https://github.com/w3c/webdriver/pull/1695
  *
  * Which corresponds to these steps in HTML:
  * https://html.spec.whatwg.org/#consume-user-activation
  *
  * @param {WindowProxy} context - Browsing context in which to run the
  *                                call.
  * @returns {Promise<boolean>} fulfilled when user activation is consumed.
  */
 consume_user_activation(context=null) {
     return window.test_driver_internal.consume_user_activation(context);
 },

@marcoscaceres marcoscaceres mentioned this pull request Nov 18, 2022
Open
@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 18, 2022

Is this covered by #127?

@foolip
Copy link
Member

foolip commented Nov 18, 2022

Is this covered by #127?

After both that and w3c/webdriver#1695 are landed, yes. But I think we can keep this as its own RFC to not depend on any of that.

foolip
foolip approved these changes Nov 18, 2022
View reviewed changes
rfcs/consume_user_activation.md Outdated Show resolved Hide resolved
rfcs/consume_user_activation.md Outdated Show resolved Hide resolved
rfcs/consume_user_activation.md Outdated Show resolved Hide resolved
marcoscaceres and others added 2 commits November 19, 2022 03:45
@foolip
Copy link
Member

foolip commented Nov 18, 2022

Per https://github.com/web-platform-tests/rfcs#the-rfc-process we can merge this if there's no further feedback in 1 week.

@jgraham
Copy link
Contributor

jgraham commented Nov 18, 2022

I don't think it makes sense to land this without the WebDriver PR landing. Without that PR, the details of this API are underspecified and it doesn't meet our bar for inclusion.

@marcoscaceres
Copy link
Contributor Author

That's ok @jgraham (and maybe we can get that landed also within a week? 🙏).

As we have multiple implementers interested, who do we need to bug over on the Web Driver side to get things moving?

@marcoscaceres marcoscaceres mentioned this pull request Nov 21, 2022
Closed
@foolip foolip changed the title RFC: Consume User Activation RFC 128: Consume User Activation Dec 6, 2022
@marcoscaceres marcoscaceres mentioned this pull request Dec 12, 2022
Merged
4 tasks
@jcscottiii
Copy link
Contributor

jcscottiii commented Mar 28, 2023 •
edited
Loading

This RFC is good to go now that the PR is merged right?
@jgraham @foolip

@jgraham
Copy link
Contributor

jgraham commented Mar 28, 2023

Per policy we no longer require an RFC for testdriver additions that correspond directly to WebDriver endpoints. So we can either merge this or not, but in any case it doesn't block adding the feature.

@jcscottiii jcscottiii merged commit 38fa8a7 into web-platform-tests:master Apr 4, 2023
@css-meeting-bot css-meeting-bot mentioned this pull request Jun 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustaqahmed mustaqahmed mustaqahmed approved these changes

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcoscaceres @Ms2ger @foolip @jgraham @jcscottiii @mustaqahmed